Modules/lvgl-module/CMakeLists.txt (1)

26-26: Remove the -D prefix — target_compile_definitions adds it automatically.

CMake's target_compile_definitions will strip a leading -D, so this works, but it's non-idiomatic and may confuse readers. The quotes are also unnecessary here.

Suggested fix

-target_compile_definitions(${MODULE_NAME} PUBLIC "-DLV_LVGL_H_INCLUDE_SIMPLE")
+target_compile_definitions(${MODULE_NAME} PUBLIC LV_LVGL_H_INCLUDE_SIMPLE)

Modules/lvgl-module/Assets/generate-all.py (2)

1-1: Remove unnecessary semicolon.

Fix

-import os;
+import os

---

23-30: Use idiomatic not in operator.

Fix

-        if not safe_name in codepoints:
+        if safe_name not in codepoints:

Tactility/Source/app/systeminfo/SystemInfo.cpp (1)

5-5: Remove stale #include <Tactility/Assets.h>.

This include is no longer used. After replacing TT_ASSETS_APP_ICON_SYSTEM_INFO with LVGL_SYMBOL_MONITORING, there are no remaining references to any Assets.h symbols in this file.

Modules/lvgl-module/Include/tactility/lvgl_fonts.h (1)

13-13: Remove commented-out code or add context.

Line 13 has a commented-out macro with no explanation of why it's disabled or when it should be re-enabled. Consider removing it to reduce noise, or add a note explaining its purpose.

Modules/lvgl-module/Source/tactility/material_symbols_shared_16.c (1)

1-5: Generated file contains local filesystem path.

Line 4 embeds the full local path /home/ken/Projects/Tactility/... from the generation command. This is harmless but leaks developer environment details. Consider stripping the -o path from the opts comment, or documenting just the relevant generation parameters.

Modules/lvgl-module/Include/tactility/lvgl_symbols_shared.h (1)

1-34: Consider adding a header comment documenting the font source.

The symbol definitions look correct — the UTF-8 encodings match the codepoints in the material_symbols_shared_16 font. A brief comment at the top indicating these are Material Design Symbols (and which font resource renders them) would help future contributors understand the relationship.

Suggested addition

 `#pragma` once
 
+// Material Design Symbols - rendered by material_symbols_shared_16 font
+// See: https://fonts.google.com/icons
+
 `#define` LVGL_SYMBOL_MAIL "\xEE\x85\x99"

Tactility/Source/app/launcher/Launcher.cpp (1)

46-60: Text color and image recolor may be redundant for symbol-rendered icons.

Line 48 sets text_color to the theme primary, which is the correct way to color LVGL symbol text rendered via lv_image. The image_recolor block (lines 53–60) was meaningful for file-based images but is likely a no-op for symbol sources. Consider whether the recolor block can be removed now that icons are font-based, or add a brief comment explaining why both are kept (e.g., fallback for mixed usage).

Modules/lvgl-module/Assets/generate-all.py (1)

1-1: Minor style issues flagged by Ruff.

Line 1: trailing semicolon. Line 27: not in is the idiomatic Python membership test.

Proposed fix

-import os;
+import os

-        if not safe_name in codepoints:
+        if safe_name not in codepoints:

Also applies to: 27-27

Tactility/Source/app/settings/Settings.cpp (1)

20-28: Duplicated widget-creation logic across three files.

This createWidget body is identical to createAppWidget in both AppSettings.cpp (line 21-27) and AppList.cpp (line 19-25). Consider extracting a shared helper (e.g., in an LVGL utility header) to avoid maintaining the same icon-fallback + font-setting logic in three places.

Modules/lvgl-module/Assets/generate-all.py (3)

1-1: Remove trailing semicolon.

-import os;
+import os

---

23-30: Use idiomatic not in operator.

Line 27: if not safe_name in codepoints should be if safe_name not in codepoints per Python style (PEP 8 / Ruff E713).

-        if not safe_name in codepoints:
+        if safe_name not in codepoints:

---

132-134: Consider making shared_symbol_font_sizes a plain list for consistency.

The other font groups pass inline lists ([20], [36]) to generate_icon_fonts. Having shared_symbol_font_sizes as a separate variable is fine, but the blank line between lines 131 and 132 visually detaches it from its symbol list. Minor readability nit.

Modules/lvgl-module/Include/tactility/lvgl_symbols_shared.h (1)

1-44: LGTM — symbol definitions are correct and complete.

All 42 macros correctly encode Material Symbol codepoints as 3-byte UTF-8 sequences in the Private Use Area (U+E000–U+F8FF), matching the 42 codepoints in the generated font file.

Minor nit: a few macros break the otherwise alphabetical ordering (DEPLOYED_CODE/DOWNLOAD after FOLDER on Lines 19–20, and NAVIGATION/KEYBOARD_ALT appended at the end on Lines 41–42). Consider sorting them for easier maintenance.